Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static check warning: not calling regexp.Match in a loop #324

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Feb 28, 2024

calling regexp.Match in a loop has poor performance, consider using regexp.Compile

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.87%. Comparing base (7953667) to head (294cdb3).

Files Patch % Lines
result_set.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   64.94%   64.87%   -0.07%     
==========================================
  Files          11       11              
  Lines        2784     2787       +3     
==========================================
  Hits         1808     1808              
- Misses        825      828       +3     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicole00 Nicole00 merged commit 9a0ce41 into vesoft-inc:master Apr 2, 2024
23 checks passed
@haoxins haoxins deleted the fix-warning branch April 2, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants