-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new method ApplyTag #317
Conversation
07ba952
to
cbc8c1b
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
==========================================
+ Coverage 63.70% 64.32% +0.61%
==========================================
Files 10 11 +1
Lines 2579 2643 +64
==========================================
+ Hits 1643 1700 +57
- Misses 797 802 +5
- Partials 139 141 +2 ☔ View full report in Codecov by Sentry. |
fb1aa2d
to
503af42
Compare
6479393
to
ada9aa4
Compare
This sugar on Client Side is so very inspiring. We should consider do similar things on all Clients. |
This is a very convenient interface that can provide users with an encapsulated and convenient interface. Thanks for your idea. |
The idea of The benefit is that we don't need to pass But I agree that it does not belong to |
|
LGTM. cc @wey-gu |
Agree with @Nicole00 that it's strange to be placed under the session_pool tent, |
We could later have some example/docs to highlight this sweet change :D |
I have another PR for ApplyEdge on the way. |
Great! Looking forward to your pr~ we have sdk api doc: https://pkg.go.dev/github.com/vesoft-inc/nebula-go/v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Great sugar!
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: