Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the go vet warnings #308

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix the go vet warnings #308

merged 2 commits into from
Jan 31, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Jan 25, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement
$ go vet ./...

# github.com/vesoft-inc/nebula-go/v3
./result_set_test.go:158:31: github.com/vesoft-inc/nebula-go/v3/nebula.Date struct literal uses unkeyed fields
./result_set_test.go:165:31: github.com/vesoft-inc/nebula-go/v3/nebula.Time struct literal uses unkeyed fields
./result_set_test.go:181:14: github.com/vesoft-inc/nebula-go/v3/nebula.Time struct literal uses unkeyed fields
./result_set_test.go:190:13: github.com/vesoft-inc/nebula-go/v3/nebula.Time struct literal uses unkeyed fields
./result_set_test.go:199:13: github.com/vesoft-inc/nebula-go/v3/nebula.Time struct literal uses unkeyed fields
./result_set_test.go:208:13: github.com/vesoft-inc/nebula-go/v3/nebula.Time struct literal uses unkeyed fields
./result_set_test.go:217:13: github.com/vesoft-inc/nebula-go/v3/nebula.Time struct literal uses unkeyed fields
./result_set_test.go:224:32: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:239:14: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:249:13: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:259:13: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:269:13: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:305:48: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:311:13: github.com/vesoft-inc/nebula-go/v3/nebula.Vertex struct literal uses unkeyed fields
./result_set_test.go:351:48: github.com/vesoft-inc/nebula-go/v3/nebula.DateTime struct literal uses unkeyed fields
./result_set_test.go:423:32: github.com/vesoft-inc/nebula-go/v3/nebula.Duration struct literal uses unkeyed fields
./result_set_test.go:545:18: github.com/vesoft-inc/nebula-go/v3/nebula/graph.ExecutionResponse struct literal uses unkeyed fields
./result_set_test.go:565:14: github.com/vesoft-inc/nebula-go/v3/nebula/graph.PlanDescription struct literal uses unkeyed fields
./result_set_test.go:567:4: *github.com/vesoft-inc/nebula-go/v3/nebula/graph.PlanNodeDescription struct literal uses unkeyed fields
./result_set_test.go:575:4: *github.com/vesoft-inc/nebula-go/v3/nebula/graph.PlanNodeDescription struct literal uses unkeyed fields
./result_set_test.go:589:11: github.com/vesoft-inc/nebula-go/v3/nebula/graph.ExecutionResponse struct literal uses unkeyed fields
./result_set_test.go:668:11: github.com/vesoft-inc/nebula-go/v3/nebula/graph.ExecutionResponse struct literal uses unkeyed fields
./result_set_test.go:715:11: github.com/vesoft-inc/nebula-go/v3/nebula/graph.ExecutionResponse struct literal uses unkeyed fields
./result_set_test.go:907:10: github.com/vesoft-inc/nebula-go/v3/nebula.Row struct literal uses unkeyed fields

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Sorry, something went wrong.

@haoxins haoxins marked this pull request as ready for review January 25, 2024 09:01
@haoxins
Copy link
Collaborator Author

haoxins commented Jan 31, 2024

cc @Nicole00 @wey-gu

@Nicole00 Nicole00 merged commit 80a0c3f into vesoft-inc:master Jan 31, 2024
20 checks passed
@haoxins haoxins deleted the types branch January 31, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants