Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for ResultSet Scan #304

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Jan 15, 2024

deps #305

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5554785) 63.37% compared to head (8dcb2f3) 63.37%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files           9        9           
  Lines        2452     2452           
=======================================
  Hits         1554     1554           
  Misses        768      768           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins marked this pull request as ready for review January 15, 2024 06:49
@QingZ11 QingZ11 requested a review from Nicole00 January 16, 2024 06:10
@Nicole00
Copy link
Contributor

the cla is not passed, could you please make some re-push to trigger the cla?

@wey-gu
Copy link
Contributor

wey-gu commented Jan 22, 2024

the cla is not passed, could you please make some re-push to trigger the cla?

Maybe the commit author is not the one @haoxins you already used?

@haoxins
Copy link
Collaborator Author

haoxins commented Jan 22, 2024

the cla is not passed, could you please make some re-push to trigger the cla?

Done~

@Nicole00 Nicole00 merged commit d8b37eb into vesoft-inc:master Jan 22, 2024
20 checks passed
@haoxins haoxins deleted the add-tests branch January 22, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants