Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nebula go client implementation #3

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Sep 24, 2019

  • Unify Connect/Disconnect interfaces same as java/cpp client implementation
  • Add editorconfig
  • Update readme for installation

Add editorconfig and use log library to output msg

Add print exec response result util function signature

Simplify nebula client

Merge open/authenticate and close/signout

Rename session ID

Rename Open/Close to Connect/Disconnect

Delete session ID parameter of Execute

Remove print response function temporarily
@yixinglu yixinglu requested review from monadbobo and dutor September 24, 2019 16:43
@yixinglu yixinglu force-pushed the refactor branch 2 times, most recently from f85ab41 to 25e025c Compare September 24, 2019 17:10
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor merged commit 9f949b7 into vesoft-inc:master Sep 25, 2019
@yixinglu yixinglu deleted the refactor branch September 25, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants