-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the tck format for the output of EXPLAIN #265
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 62.29% 61.26% -1.03%
==========================================
Files 9 9
Lines 2270 2308 +38
==========================================
Hits 1414 1414
- Misses 711 749 +38
Partials 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests to this PR? You could choose a test case from the .feature
files from the Nebula repo and add it here.
Alright, I had considered adding some tests before. However, this feature only aims to specify the output format for explain/profile.
|
Makes sense. |
1 similar comment
Makes sense. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
vesoft-inc/nebula#5274
Description:
Support the tck format for the output of EXPLAIN
How do you solve it?
In
nebula-go
,I have added a function calledMakePlanByTck()
, which is designed to return TCK-formatted result sets for theNebula Console
.The
MakePlanByTck()
function will sequentially add columns fordependencies
,profiling data
, and emptyoperator info
.Since
profiling data
andoperator info
are also needed in the Row-formatted, the logic for generatingprofiling data
andoperator info
have been separated into individual functionsMakeProfilingData()
andMakeOperatorInfo()
for reusability.Special notes for your reviewer, ex. impact of this fix, design document, etc:
related link: