Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check connection unreachable host #142

Closed
wants to merge 5 commits into from

Conversation

HarrisChu
Copy link
Contributor

  1. if init pool with MinConnPoolSize, and there's an unreachable host, then it would be failed.
  2. if get a session with GetSession, as we have retry, it would be timeout firstly, then get an available connect.

Verified

This commit was signed with the committer’s verified signature.
timvandijck Tim Van Dijck
@Aiee Aiee mentioned this pull request Oct 26, 2021
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the original proposal is to do the check during the initialization of the connection pool

Comment on lines 55 to 57
func (cn *connection) open(hostAddress HostAddress, timeout time.Duration) error {
return cn.openSSL(hostAddress, timeout, nil)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check open() as well as openSSL()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close this pr, do not check it in open method, as this would open two times.
will check it in the initialization.

@HarrisChu
Copy link
Contributor Author

close this pr, do not check it in open method, as this would open two times.
will check it in the initialization.

@HarrisChu HarrisChu closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants