Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NebulaPool's not serializable & refactor ssl #32

Merged
merged 8 commits into from
Nov 1, 2021

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Nov 1, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #32 (722aae5) into master (6541047) will increase coverage by 0.20%.
The diff coverage is 69.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     39.83%   40.04%   +0.20%     
- Complexity      142      144       +2     
============================================
  Files            46       46              
  Lines          1373     1371       -2     
  Branches        128      128              
============================================
+ Hits            547      549       +2     
+ Misses          776      772       -4     
  Partials         50       50              
Impacted Files Coverage Δ
...connector/nebula/sink/NebulaBatchOutputFormat.java 46.87% <50.00%> (+1.71%) ⬆️
...bula/connection/NebulaGraphConnectionProvider.java 83.33% <76.47%> (+11.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6541047...722aae5. Read the comment docs.

@Nicole00 Nicole00 requested a review from HarrisChu November 1, 2021 06:57
Copy link
Contributor

@HarrisChu HarrisChu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00 Nicole00 merged commit 7272b2e into vesoft-inc:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants