-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batch update for nebula-exchange #154
Conversation
…nebula-exchange into batch-delete-exchange
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
============================================
+ Coverage 56.01% 56.25% +0.23%
- Complexity 83 89 +6
============================================
Files 18 18
Lines 1655 1712 +57
Branches 315 325 +10
============================================
+ Hits 927 963 +36
- Misses 556 567 +11
- Partials 172 182 +10
☔ View full report in Codecov by Sentry. |
@@ -248,10 +345,10 @@ class NebulaGraphClientWriter(dataBaseConfigEntry: DataBaseConfigEntry, | |||
} | |||
|
|||
override def writeEdges(edges: Edges, ignoreIndex: Boolean = false): String = { | |||
val sentence = toExecuteSentence(config.name, edges, ignoreIndex) | |||
// val sentence = toExecuteSentence(config.name, edges, ignoreIndex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just remove this line. same for writeVertices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I got it~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just remove this line. same for writeVertices.
Done~
LGTM!great job, thanks for your contribution~ @EldinZhou |
…xchange into batch-delete-exchange
@cooper-lzy Now we can support batch update function in Exchange, the config is the same as batch delete: there's one extra config named |
Add batch update statements for vertices and edges with unit tests.