Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batch update for nebula-exchange #154

Merged
merged 8 commits into from
Aug 9, 2023

Conversation

EldinZhou
Copy link
Contributor

Add batch update statements for vertices and edges with unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Patch coverage: 58.06% and project coverage change: +0.23% 🎉

Comparison is base (1f40692) 56.01% compared to head (274cb19) 56.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     56.01%   56.25%   +0.23%     
- Complexity       83       89       +6     
============================================
  Files            18       18              
  Lines          1655     1712      +57     
  Branches        315      325      +10     
============================================
+ Hits            927      963      +36     
- Misses          556      567      +11     
- Partials        172      182      +10     
Files Changed Coverage Δ
...soft/exchange/common/writer/ServerBaseWriter.scala 37.17% <58.06%> (+8.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wey-gu wey-gu requested a review from Nicole00 August 8, 2023 01:49
@@ -248,10 +345,10 @@ class NebulaGraphClientWriter(dataBaseConfigEntry: DataBaseConfigEntry,
}

override def writeEdges(edges: Edges, ignoreIndex: Boolean = false): String = {
val sentence = toExecuteSentence(config.name, edges, ignoreIndex)
// val sentence = toExecuteSentence(config.name, edges, ignoreIndex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just remove this line. same for writeVertices.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I got it~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just remove this line. same for writeVertices.

Done~

@Nicole00
Copy link
Contributor

Nicole00 commented Aug 8, 2023

LGTM!great job, thanks for your contribution~ @EldinZhou

@Nicole00 Nicole00 merged commit 6e838bf into vesoft-inc:master Aug 9, 2023
@Nicole00 Nicole00 added the doc affected PR: improvements or additions to documentation label Aug 9, 2023
@Nicole00
Copy link
Contributor

Nicole00 commented Aug 9, 2023

@cooper-lzy Now we can support batch update function in Exchange, the config is the same as batch delete: there's one extra config named writeMode for each tag or edge. the value can be insert,delete and update, and default value is insert. https://github.com/vesoft-inc/nebula-exchange/pull/151/files#diff-a55ebb9daa91e9046a352946a76fff36b82f42d2a31881983c4a57abb2b70f8d

@Nicole00 Nicole00 changed the title Batch update exchange add batch update for nebula-exchange Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants