-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batch delete for nebula-exchange #151
Conversation
Wow, @EldinZhou thanks a lot for the great work!!! Could you please help sign the CLA? cc @Nicole00 we have a deletion impl. now! |
Ok, no problem!
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Wey Gu ***@***.***>
发送时间: Monday, July 24, 2023 2:49:40 PM
收件人: vesoft-inc/nebula-exchange ***@***.***>
抄送: Zhou Ziyi ***@***.***>; Mention ***@***.***>
主题: Re: [vesoft-inc/nebula-exchange] add batch delete for nebula-exchange (PR #151)
- External Email -
Wow, @EldinZhou<https://github.com/EldinZhou> thanks a lot for the great work!!!
Could you please help sign the CLA?
cc @Nicole00<https://github.com/Nicole00> we have a deletion impl. now!
―
Reply to this email directly, view it on GitHub<#151 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP63AEQURLBYIOV5WFURKC3XRYLIJANCNFSM6AAAAAA2VBQHSA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!Excellent job!
please check the compile error and sign cla~ |
CLA sign done~ |
maybe fix the error caused by typo of writeMode |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
============================================
- Coverage 56.57% 56.01% -0.57%
- Complexity 79 83 +4
============================================
Files 18 18
Lines 1566 1655 +89
Branches 297 315 +18
============================================
+ Hits 886 927 +41
- Misses 519 556 +37
- Partials 161 172 +11
☔ View full report in Codecov by Sentry. |
@cooper-lzy Now we can support batch delete function for exchange, the config example can be found in https://github.com/vesoft-inc/nebula-exchange/pull/151/files#diff-a55ebb9daa91e9046a352946a76fff36b82f42d2a31881983c4a57abb2b70f8d. |
Add batch delete for nebula-exchange with unit tests for config parsing and execute delete statements