Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batch delete for nebula-exchange #151

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

EldinZhou
Copy link
Contributor

Add batch delete for nebula-exchange with unit tests for config parsing and execute delete statements

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@EldinZhou EldinZhou changed the title Batch delete exchange Batch delete for nebula-exchange Jul 24, 2023
@EldinZhou EldinZhou changed the title Batch delete for nebula-exchange add batch delete for nebula-exchange Jul 24, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Jul 24, 2023

Wow, @EldinZhou thanks a lot for the great work!!!

Could you please help sign the CLA?

cc @Nicole00 we have a deletion impl. now!

@wey-gu wey-gu requested a review from Nicole00 July 24, 2023 06:49
@EldinZhou
Copy link
Contributor Author

EldinZhou commented Jul 24, 2023 via email

Nicole00
Nicole00 previously approved these changes Jul 25, 2023
Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Excellent job!

@Nicole00
Copy link
Contributor

please check the compile error and sign cla~

@EldinZhou
Copy link
Contributor Author

please check the compile error and sign cla~

CLA sign done~

@EldinZhou
Copy link
Contributor Author

please check the compile error and sign cla~

maybe fix the error caused by typo of writeMode

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 45.74% and project coverage change: -0.57% ⚠️

Comparison is base (3f27691) 56.57% compared to head (81d8317) 56.01%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
- Coverage     56.57%   56.01%   -0.57%     
- Complexity       79       83       +4     
============================================
  Files            18       18              
  Lines          1566     1655      +89     
  Branches        297      315      +18     
============================================
+ Hits            886      927      +41     
- Misses          519      556      +37     
- Partials        161      172      +11     
Files Changed Coverage Δ
...soft/exchange/common/writer/ServerBaseWriter.scala 28.81% <30.88%> (+2.02%) ⬆️
.../vesoft/exchange/common/config/SchemaConfigs.scala 74.72% <83.33%> (+0.60%) ⬆️
...la/com/vesoft/exchange/common/config/Configs.scala 63.11% <85.00%> (+0.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wey-gu wey-gu requested a review from Nicole00 July 27, 2023 02:05
@Nicole00 Nicole00 merged commit 68ef4c4 into vesoft-inc:master Jul 27, 2023
@Nicole00
Copy link
Contributor

Nicole00 commented Aug 9, 2023

@cooper-lzy Now we can support batch delete function for exchange, the config example can be found in https://github.com/vesoft-inc/nebula-exchange/pull/151/files#diff-a55ebb9daa91e9046a352946a76fff36b82f42d2a31881983c4a57abb2b70f8d.

@Nicole00 Nicole00 added the doc affected PR: improvements or additions to documentation label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants