Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of guava dependency #148

Merged
merged 5 commits into from
Jul 4, 2023
Merged

get rid of guava dependency #148

merged 5 commits into from
Jul 4, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Jul 3, 2023

get rid of guava to avoid jar conflict.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: +0.11 🎉

Comparison is base (f628fb9) 56.13% compared to head (a346737) 56.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
+ Coverage     56.13%   56.24%   +0.11%     
+ Complexity       85       79       -6     
============================================
  Files            18       18              
  Lines          1525     1554      +29     
  Branches        287      297      +10     
============================================
+ Hits            856      874      +18     
- Misses          515      519       +4     
- Partials        154      161       +7     
Impacted Files Coverage Δ
...la/com/vesoft/exchange/common/config/Configs.scala 62.03% <0.00%> (ø)
...cala/com/vesoft/exchange/common/MetaProvider.scala 70.49% <66.66%> (-1.39%) ⬇️
...com/vesoft/exchange/common/utils/NebulaUtils.scala 68.04% <68.57%> (+0.29%) ⬆️
...ala/com/vesoft/exchange/common/GraphProvider.scala 64.00% <100.00%> (-3.86%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

wey-gu
wey-gu previously approved these changes Jul 4, 2023
@Nicole00
Copy link
Contributor Author

Nicole00 commented Jul 4, 2023

@wey-gu please help to review again, thanks~~

@Nicole00 Nicole00 merged commit 934c23f into vesoft-inc:master Jul 4, 2023
@Nicole00 Nicole00 deleted the guava branch July 4, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants