Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conf template #105

Merged
merged 2 commits into from
Nov 30, 2022
Merged

add conf template #105

merged 2 commits into from
Nov 30, 2022

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Nov 4, 2022

No description provided.

@Nicole00 Nicole00 requested a review from MuYiYong November 4, 2022 07:01
@Nicole00
Copy link
Contributor Author

Nicole00 commented Nov 4, 2022

@MuYiYong Please list more datasources that we need to give the config templates. In this pr, just provide config template for csv and hive for both client import and sst import.

@codecov-commenter
Copy link

Codecov Report

Base: 55.67% // Head: 55.67% // No change to project coverage 👍

Coverage data is based on head (ce2d834) compared to base (b86efc5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage     55.67%   55.67%           
  Complexity       81       81           
=========================================
  Files            17       17           
  Lines          1419     1419           
  Branches        267      267           
=========================================
  Hits            790      790           
  Misses          489      489           
  Partials        140      140           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 requested a review from Sophie-Xie November 4, 2022 08:07
@MuYiYong
Copy link

MuYiYong commented Nov 30, 2022

@MuYiYong Please list more datasources that we need to give the config templates. In this pr, just provide config template for csv and hive for both client import and sst import.

CSV on S3, HBase,Hive, MySQL,neo4j, MaxCompute,kafka, SST

Copy link

@MuYiYong MuYiYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Nicole00
Copy link
Contributor Author

@MuYiYong Please list more datasources that we need to give the config templates. In this pr, just provide config template for csv and hive for both client import and sst import.

CSV on S3, HBase,Hive, MySQL,neo4j, MaxCompute,kafka, SST

There are CSV, Hive, SST config templates already. I can add config template for neo4j, MaxCompute and Kafka.
But:

  • We DO NOT support S3.
  • HBase datasource is not typical, no need to provide config template.
  • For MySQL, maybe JDBC is better?

@Nicole00 Nicole00 merged commit e9c6aad into vesoft-inc:master Nov 30, 2022
@Nicole00 Nicole00 deleted the conf_template branch November 30, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants