Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename blackbox #2760

Merged
merged 1 commit into from
May 16, 2023
Merged

rename blackbox #2760

merged 1 commit into from
May 16, 2023

Conversation

cooper-lzy
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and the code changes are consistent with each other.
The code changes rename "blackbox" to "{{bbox.name}}" throughout the codebase.
The change updates the documentation files 3.1.bbox.md and 3.2.bbox-reviewer.md in the 6.monitor-and-metrics/3.bbox directory.
In 3.1.bbox.md:
The title is updated from {{bbox.name}}介绍 to 黑匣子介绍.
The introductory paragraph is modified to mention that {{nebula.name}} comes with the black box functionality.
The section title "功能说明" remains unchanged.
The section title "查看和分析黑匣子文件" is updated to "查看黑匣子文件."
The paragraph mentioning "NebulaGraph Black Box 工具" is updated to mention {{bbox.name}} instead.
In 3.2.bbox-reviewer.md:
The title is updated from "黑匣子工具 NebulaGraph Black Box" to "使用{{bbox.name}}."
The introductory paragraph is updated to mention {{bbox.name}} instead of "NebulaGraph Black Box."
The section title "Nebula-BBox 的功能" is updated to "{{bbox.name}}的功能."
The section title "部署 Nebula-BBox" is updated to "部署{{bbox.name}}."
The paragraph mentioning "Nebula-BBox" is updated to "{{bbox.name}}."
The section title "使用 Nebula-BBox" is updated to "使用{{bbox.name}}."
The paragraph mentioning "Nebula-BBox" is updated to "{{bbox.name}}."
The subsection title "查看 Nebula-BBox 版本" is updated to "查看{{bbox.name}}版本."
The subsection title "查看采集的所有指标" remains unchanged.
The subsection title "查看黑匣子文件数据" is updated to "通过{{bbox.name}}查看黑匣子文件数据."
The command examples that mention "nebula-bbox" are updated to "{{bbox.name}}."
Overall, the code changes successfully rename "blackbox" to "{{bbox.name}}" consistently throughout the codebase and documentation. The changes align with the commit message, and the code now reflects the updated naming convention.

@whitewum whitewum merged commit 2eb1bc7 into vesoft-inc:master May 16, 2023
@cooper-lzy cooper-lzy deleted the rename-blackbox branch August 11, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants