Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a new method to deploy dashboard #1896

Merged
merged 3 commits into from
Jun 23, 2022
Merged

add a new method to deploy dashboard #1896

merged 3 commits into from
Jun 23, 2022

Conversation

abby-cyber
Copy link
Contributor

No description provided.

@wey-gu
Copy link
Contributor

wey-gu commented Jun 23, 2022 •
edited
Loading

Great work, thanks. Also, for the dashboard playground itself, do you think it's worthy to be documented, too?

https://github.com/vesoft-inc/nebula-dashboard/tree/master/playground

Or, maybe it could be mentioned in README only.

@abby-cyber
Copy link
Contributor Author

Great work, thanks. Also, for the dashboard playground itself, do you think it's worthy to be documented, too?

https://github.com/vesoft-inc/nebula-dashboard/tree/master/playground

Or, maybe it could be mentioned in README only.

Good idea! Will do it soon. I thought we'd added links to dashboard/explorer playgrounds. Thanks for the reminder. @foesa-yang

@wey-gu
Copy link
Contributor

wey-gu commented Jun 23, 2022

Great work, thanks. Also, for the dashboard playground itself, do you think it's worthy to be documented, too?
https://github.com/vesoft-inc/nebula-dashboard/tree/master/playground
Or, maybe it could be mentioned in README only.

Good idea! Will do it soon. I thought we'd added links to dashboard/explorer playgrounds. Thanks for the reminder. @foesa-yang

Thanks @abby-cyber :) also, kindly check my inline review comments

@whitewum whitewum merged commit f1bf65e into vesoft-inc:master Jun 23, 2022
@wey-gu wey-gu mentioned this pull request Jun 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wey-gu wey-gu wey-gu left review comments

@cooper-lzy cooper-lzy cooper-lzy approved these changes

@whitewum whitewum whitewum approved these changes

@xigongdaEricyang xigongdaEricyang Awaiting requested review from xigongdaEricyang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abby-cyber @wey-gu @whitewum @cooper-lzy