fix: use fully qualified image names

[ctron]

What type of PR is this?

• bug
• feature
• enhancement

What problem(s) does this PR solve?

Issue(s) number:

• Deployment might pull unintended images
• Deployment gets stuck on systems asking for confirmation of non-qualified images

Description:

Using an unqualified image name might yield different results on different systems. The deployment actually relies on docker's default, which is 'docker.io'. Other system might not have this default, and some systems might even pause and interactively ask the user for a decision.

How do you solve it?

Providing a fully qualified image name solves this issues and ensures that the intended image is pulled.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

[CLAassistant]

All committers have signed the CLA.

[wey-gu]

Dear @ctron ,

Thanks a lot for the contribution, indeed this(no fqdn approach) is implicit.

In case we are in env w/o proper internet access, thus using docker registry mirrors, will this fqdn approach bypass the mirror due to such explicit image names, please?

Thanks.

BR//Wey

[ctron]

I think in a case without internet access, using a proxy is the right approach: https://docs.docker.com/config/daemon/systemd/#httphttps-proxy

I tried to some reasonable explanation on what registry-mirrors actually does. But couldn't find any, other some some vague statements.

I did find some documentation from Google on this: https://cloud.google.com/container-registry/docs/pulling-cached-images … it reads like the mirror can just mirror anything. So expectation would be, that it also can pull docker.io images.

[wey-gu]

Thanks a lot, @ctron !

I'll also double-check/reproduce that mirror will go through these fqdn images, too, as in China, the traffic to the docker hub is impacted, thus many of us will use a docker hub mirror to enable the image pulling, thus it's not the same case as w/o internet(to use a proxy). In case that is the case, we could consider putting the default compose file as you changed and create another one in non-fqdn fashion.

Thanks!

[Nicole00]

LGTM