Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service metric don't show different metricType chart #182

Merged
merged 1 commit into from
Dec 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Charts/LineChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ function LineChart(props: IProps, ref) {
tickInterval,
},
});
autoAdjustPadding(options.valueType);
return chartInstanceRef.current;
};

Expand Down
16 changes: 0 additions & 16 deletions src/components/ServiceMetricsFilterPanel/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,6 @@ function ServiceMetricsFilterPanel(props: IProps) {
onChange?.(form.getFieldsValue());
}

const handlePeriodChange = (value) => {
if (!form) return;
form.setFieldsValue({
period: value,
});
onChange?.(form.getFieldsValue());
}

const handleMetricTypeChange = (value) => {
if (!form) return;
form.setFieldsValue({
metricType: value,
});
onChange?.(form.getFieldsValue());
}

const handleFilterPanelChange = () => {
onChange?.(form.getFieldsValue());
}
Expand Down
76 changes: 24 additions & 52 deletions src/pages/ServiceDashboard/Detail/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -105,25 +105,11 @@ function ServiceDetail(props: IProps) {
return options;
}, [serviceType, serviceMetric.graphd, serviceMetric.metad, serviceMetric.storaged, serviceMetric.drainerd, serviceMetric['metad-listener'], serviceMetric['storaged-listener']]);

const metricTypeMap: Map<AggregationType, IServiceMetricItem[]> = useMemo(() => {
const map: Map<AggregationType, IServiceMetricItem[]> = {} as any;
metricOptions.forEach(option => {
option.aggregations.forEach(type => {
if (!map[type]) {
map[type] = [option];
} else {
map[type].push(option)
}
})
})
return map;
}, [metricOptions]);

const metricNameList: string[] = useMemo(() => (
(metricOptions || []).map((metric) => metric.metric)
), [metricOptions]);

const [curMetricOptions, setMetricOptions] = useState<IServiceMetricItem[]>([]);
const [metricCharts, setMetricCharts] = useState<{ metric:IServiceMetricItem,index:number,baseLine:any,chartRef?:any,visible:boolean }[]>([]);

useEffect(() => {
const match = /(\w+)-metrics/g.exec(location.pathname);
Expand All @@ -135,26 +121,6 @@ function ServiceDetail(props: IProps) {
setServiceType(serviceType);
}, [location]);

const metricCharts: any = useMemo(() => {
if (Object.keys(metricTypeMap).length === 0) return [];
const { metricType } = metricsFilterValues;
let charts: any = [];
if (metricType === 'all') {
charts = metricOptions.map((metric, i) => ({
metric,
index: i,
baseLine: undefined,
}))
} else {
charts = (metricTypeMap[metricType] || []).map((metric, i) => ({
metric,
index: i,
baseLine: undefined,
}));
}
return charts;
}, [metricTypeMap, metricsFilterValues.metricType])

useEffect(() => {
clearPolling();
if (shouldCheckCluster()) {
Expand All @@ -178,27 +144,28 @@ function ServiceDetail(props: IProps) {
};

useEffect(() => {
setMetricOptions(metricOptions)
setMetricCharts(metricOptions.map((metric, index) => ({ metric, index, baseLine: null,visible:true })));
}, [metricOptions])

useEffect(() => {
if (dataSources.length === 0) return;
updateChart();
}, [metricsFilterValues.instanceList, dataSources, curMetricOptions])
}, [metricsFilterValues.instanceList, dataSources, metricCharts])

useEffect(() => {
if (pollingTimerRef.current) {
clearPolling();
pollingData();
}
}, [curMetricOptions])
}, [metricCharts])

const asyncGetMetricsData = async () => {
const { timeRange, period, space, metricType } = metricsFilterValues;
const { timeRange, period="5", space, } = metricsFilterValues;
const [startTime, endTime] = calcTimeRange(timeRange);
const getPromise = (chart) => {
return new Promise((resolve, reject) => {
const item: IServiceMetricItem = metricTypeMap[metricType].find(metricItem => metricItem.metric === chart.metric.metric);
const item: IServiceMetricItem = chart.metric;
const metricType = item.aggregations[0] as AggregationType;
asyncFetchMetricsData({
query: getQueryByMetricType(item, metricType, period),
start: startTime,
Expand All @@ -215,7 +182,7 @@ function ServiceDetail(props: IProps) {
}
if (metricCharts.length === 0) return;
Promise.all(metricCharts.map((chart, i) => {
if (curMetricOptions.length === 0 || curMetricOptions.find(m => m.metric === chart.metric.metric)) {
if (chart.visible) {
return getPromise(chart);
} else {
return Promise.resolve(dataSources[i]);
Expand Down Expand Up @@ -255,11 +222,15 @@ function ServiceDetail(props: IProps) {
};

const renderChart = (i: number) => () => {
const chart = metricCharts[i];
const [startTimestamps, endTimestamps] = calcTimeRange(metricsFilterValues.timeRange);
metricCharts[i].chartRef.configDetailChart({
chart.chartRef.configDetailChart({
tickInterval: getProperTickInterval(endTimestamps - startTimestamps),
valueType: metricCharts[i].metric.valueType,
valueType: chart.metric.valueType,
});
if (chart.visible&&chart.baseLine) {
chart.chartRef.updateBaseline(chart.baseLine);
}
};

const handleBaseLineEdit = (metricChart) => () => {
Expand Down Expand Up @@ -292,17 +263,18 @@ function ServiceDetail(props: IProps) {
asyncGetMetricsData();
}

const handleMetricsChange = (values) => {
const handleMetricsChange = (values) => {
if (values.length === 0) {
setMetricOptions(metricOptions);
metricCharts.forEach(chart => {
chart.visible = true;
})
} else {
setMetricOptions(metricOptions.filter(metric => values.includes(metric.metric)));
metricCharts.forEach(chart => {
chart.visible = values.includes(chart.metric.metric);
})
}
}

const shouldShow = (metricItem) => {
return curMetricOptions.find(item => item.metric === metricItem.metric)
}
setMetricCharts([...metricCharts]);
}

const getViewPath = (path: string): string => {
if (cluster?.id) {
Expand Down Expand Up @@ -350,7 +322,7 @@ function ServiceDetail(props: IProps) {
{
metricCharts.length ? (
metricCharts.map((metricChart, i) => (
<div key={i} className='chart-item' style={{ display: shouldShow(metricChart.metric) ? 'flex' : 'none' }}>
<div key={i} className='chart-item' style={{ display: metricChart.visible ? 'flex' : 'none' }}>
<div className='chart-title'>
{metricChart.metric.metric}
<Popover
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function CustomServiceQueryPanel(props: IProps) {
const item = (serviceMetric[serviceType] as IServiceMetricItem[]).find((metricItem: IServiceMetricItem) => metricItem.metric === metric);
if (item) {
const data = await asyncGetMetricsData({
query: getQueryByMetricType(item, aggregation, metricPeriod.toString()), // EXPLAIN: query like nebula_graphd_num_queries_rate_600
query: getQueryByMetricType(item, aggregation, metricPeriod?.toString()), // EXPLAIN: query like nebula_graphd_num_queries_rate_600
start,
end,
space,
Expand Down
3 changes: 1 addition & 2 deletions src/pages/ServiceManage/LeaderDistribution/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@ const LeaderDistribution: React.FC<IProps> = (props: IProps) => {
const updateChart = () => {
if (data.length > 0) {
const lastItem = last(data);
const total = lastItem!.count;
const hostList =
lastItem!.name === 'Total' ? data.slice(0, data.length - 1) : data;
const chartData = hostList.map(item => ({
type: item.name,
value: total ? round(item.count / total, 2) : 1,
value: item.count
}));
chartInstance?.data(chartData).render();
}
Expand Down
4 changes: 4 additions & 0 deletions src/pages/ServiceManage/Overview/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const mapDispatch: any = (dispatch: IDispatch) => ({
asyncGetHostsInfo: dispatch.nebula.asyncGetHostsInfo,
asyncGetServices: dispatch.nebula.asyncGetServices,
asyncExecNGQL: dispatch.nebula.asyncExecNGQL,
clear: dispatch.nebula.clear,
});

const mapState = (state: IRootState) => ({
Expand Down Expand Up @@ -60,6 +61,9 @@ const Overview: React.FC<IProps> = (props: IProps) => {
const modalHandler = useRef<any>();
const [hosts, setHosts] = useState([]);

useEffect(() => {
props.clear();
},[cluster])
useEffect(() => {
if (nebulaConnect) {
asyncGetHostsInfo();
Expand Down
11 changes: 11 additions & 0 deletions src/store/models/nebula.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,17 @@ export function NebulaModelWrapper(serviceApi, state, _effects) {
}));
return versionInfos;
},

clear() {
this.update({
configs: [],
jobs: [],
spaces: [],
parts: [],
services: [],
currentSpace: null,
});
},
..._effects(dispatch),
}),
})
Expand Down
11 changes: 6 additions & 5 deletions src/utils/dashboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,10 @@ export const getMaxNumAndLength = (payload: {
}) => {
const { data = [], valueType, baseLine } = payload;
const maxNum = getMaxNum(data);
let maxNumLen =
maxNum === 0 && baseLine
? baseLine.toString().length
: maxNum.toString().length;
let maxString = maxNum === 0 && baseLine
? baseLine.toString()
: maxNum.toString();
let maxNumLen = maxString.length;
switch (valueType) {
case VALUE_TYPE.percentage:
maxNumLen = 5;
Expand All @@ -375,8 +375,9 @@ export const getMaxNumAndLength = (payload: {
maxNumLen = unit.length + value.toString().length + 2;
break;
}
case VALUE_TYPE.number:
case VALUE_TYPE.numberSecond:
maxNumLen += 2;
maxNumLen = maxString.split('.')[0].length ;
break;
default:
break;
Expand Down