Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]add config parse for degree algorithm #77

Conversation

fbpcchen
Copy link
Contributor

@fbpcchen fbpcchen commented Jun 1, 2023

…ic 算法上跑通

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2023

CLA assistant check
All committers have signed the CLA.

@wey-gu wey-gu requested a review from Nicole00 June 1, 2023 13:41
@wey-gu
Copy link
Contributor

wey-gu commented Jun 1, 2023

Thanks @fbpcchen for the contribution :) could you please sign the CLA?

@fbpcchen
Copy link
Contributor Author

fbpcchen commented Jun 2, 2023

Thanks @fbpcchen for the contribution :) could you please sign the CLA?

signed.

wey-gu
wey-gu previously approved these changes Jun 10, 2023
@@ -53,6 +53,17 @@ object DecodeUtil {
(encodeDataframe, encodeId)
}

def convertEncodeId2StringId(dataframe: DataFrame, encodeId: DataFrame): DataFrame = {
Copy link
Contributor

@Nicole00 Nicole00 Jun 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between convertEncodeId3StringId and convertAlgoId2StringId?

Copy link
Contributor Author

@fbpcchen fbpcchen Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-examined and tested the code, and found that it is indeed the same.
It should be a misjudgment caused by the problem of receiving the encodeId parameter of the degree_static algorithm.
Let me resubmit the code that only just solves the algorithm encodeId configuration parameter passing problem.

@Nicole00 Nicole00 changed the title ✨ 正确关联配置 encodeId 时结果集 df 与 encodeId df 得到正确结果,在 degree_stat… add config parse for degree algorithm Jun 16, 2023
@Nicole00 Nicole00 changed the title add config parse for degree algorithm [fix]add config parse for degree algorithm Jun 16, 2023
Nicole00
Nicole00 previously approved these changes Jun 16, 2023
Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00
Copy link
Contributor

Hi @fbpcchen , looks like the cla does not take effect, could you please re-sign the cla and re-push?

@wey-gu
Copy link
Contributor

wey-gu commented Jun 16, 2023

@fbpcchen maybe you should modify the commit's git author(both name and email) on the local branch and push force.

陈燃 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@fbpcchen fbpcchen force-pushed the feature/20230601_upgrade_degree_static_encodeId_result branch from 0cffb91 to 14c82c0 Compare June 16, 2023 03:52
@fbpcchen
Copy link
Contributor Author

@fbpcchen maybe you should modify the commit's git author(both name and email) on the local branch and push force.

陈燃 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

done

@fbpcchen
Copy link
Contributor Author

Hi @fbpcchen , looks like the cla does not take effect, could you please re-sign the cla and re-push?

It is the authentication problem of the commit I submitted , please review it again.

@wey-gu wey-gu requested a review from Nicole00 June 16, 2023 04:00
@Nicole00 Nicole00 merged commit 3fc5955 into vesoft-inc:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants