-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]add config parse for degree algorithm #77
[fix]add config parse for degree algorithm #77
Conversation
Thanks @fbpcchen for the contribution :) could you please sign the CLA? |
signed. |
@@ -53,6 +53,17 @@ object DecodeUtil { | |||
(encodeDataframe, encodeId) | |||
} | |||
|
|||
def convertEncodeId2StringId(dataframe: DataFrame, encodeId: DataFrame): DataFrame = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between convertEncodeId3StringId and convertAlgoId2StringId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-examined and tested the code, and found that it is indeed the same.
It should be a misjudgment caused by the problem of receiving the encodeId parameter of the degree_static algorithm.
Let me resubmit the code that only just solves the algorithm encodeId configuration parameter passing problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @fbpcchen , looks like the cla does not take effect, could you please re-sign the cla and re-push? |
@fbpcchen maybe you should modify the commit's git author(both name and email) on the local branch and push force.
|
0cffb91
to
14c82c0
Compare
done |
It is the authentication problem of the commit I submitted , please review it again. |
…ic 算法上跑通
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: