Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mail client pkg #10

Merged
merged 1 commit into from
Mar 31, 2022
Merged

add mail client pkg #10

merged 1 commit into from
Mar 31, 2022

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented Mar 29, 2022 •
edited
Loading

  • add mail client pkg
  • 100% test coverage

fixed: #6

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #10 (ac0f2a3) into master (d1df1cc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          329       343   +14     
=========================================
+ Hits           329       343   +14
Impacted Files Coverage Δ
mail/mail.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1df1cc...ac0f2a3. Read the comment docs.

@veezhang veezhang force-pushed the mail branch 4 times, most recently from 4aed513 to d05a345 Compare March 30, 2022 12:20
kqzh
kqzh approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@kqzh kqzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kqzh kqzh merged commit 17f5905 into vesoft-inc:master Mar 31, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqzh kqzh kqzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mail pkg
3 participants
@veezhang @codecov-commenter @kqzh