-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't require twitter #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy isn't ready yet, and im not convinced it matches these purposes anyway. This reverts commit 04c6900.
Also, abstract out the display of show dates to a dedicated include.
The form does not yet show you what you're requesting. This is a problem. It also probably shouldn't open in a new tab.
It's not needed.
The view should do this every time. There's no reason for it to ever pass through the user's hands.
It's not an external site any more.
Also, remove a CSS hack that was only necessary due to this HTML being as broken as it was.
This template is just stolen directly from Django's, with some whitespace changes. Now, I need to actually fix the problems I have with it.
I'm still not happy with this. The way these forms are laid out just does not mesh with the way these widgets work, and it ends up looking kinda ugly. This, at least, makes it look less broken.
This will probably make the website noticably slower in some cases. It's necessary, though, or you'll get a random other user's eligibility state.
This method gets called a lot, so this should help things.
I actually caught this one the first time, I just didn't save the file.
We had talked about mentioning what has changed as a result of #235 here, but on reflection, I don't think that makes much sense. Existing users are going to behave habitually, and we have placed a net to catch them in the form of the login page. There's no reason to mention any of this stuff to new users.
It was never really necessary to do it at times other than migrations.
I think opening with this is a good idea, just to make sure we're on the same page as the reader. Without this context, it might be possible for someone to come away being unsure why we want them to do this, and I can imagine that being a pretty confusing experience.
four icons, each in 24 hues, generated programmatically. the only thing changing between icons is the <path> element, and the only thing changing between hues is the fill: style on that path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authentication stuff:
XXX
commentuser management:
noise.png
TwitterUser
s, toobasic workflow:
moderation tools:
communications: