Close socket on tls n response #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sitingren
reviewed
Feb 2, 2023
| @@ -541,6 +541,7 @@ def enable_ssl(self, raw_socket, ssl_options): | |||
| else: | |||
| err_msg = "SSL requested but not supported by server" | |||
| self._logger.error(err_msg) | |||
| self.close_socket() | |||
There was a problem hiding this comment.
This close_socket() function only works when the connection is established, enabling TLS is just before that step. So this line actually doesn't take effect.
There was a problem hiding this comment.
Ah okay. I originally had raw_socket.close() before seeing the close_socket function, but that makes sense. I'll close this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to make sure the socket is closed when SSL negotiation winds up restricting the opening of an SSL Socket.