Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for enum with custom constructor #115

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

cvgaviao
Copy link
Contributor

eclipse-vertx/vertx-codegen#295

Signed-off-by: Cristiano V. Gavião [email protected]

Motivation:

Explain here the context, and why you're making that change, what is the problem you're trying to solve.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@cvgaviao
Copy link
Contributor Author

@vietj, it is ready and I also added some tests

@vietj
Copy link
Contributor

vietj commented May 29, 2020

I think we need the test to be in codegen TCK and have an implementation for vertx-rx as well.

@cvgaviao
Copy link
Contributor Author

cvgaviao commented Jun 5, 2020

I think we need the test to be in codegen TCK and have an implementation for vertx-rx as well.

@vietj , there is no use of any enum in the rx codegen projects, I run it's building and all tests have passed.

So, why this and vertx-codegen PR for custom enums should wait for vertx-rx?

@vietj
Copy link
Contributor

vietj commented Jun 5, 2020 via email

@cvgaviao
Copy link
Contributor Author

cvgaviao commented Jun 5, 2020

there should be an example in TCK that uses an enum mapped with a mapper and the vertx-rx should handle it fine (I think there is nothing to do) but nevertheless such test should be in TCK, because some other impls like ES4X will need this.

Well, I think I did it.

Signed-off-by: Cristiano V. Gavião <[email protected]>
@cvgaviao cvgaviao force-pushed the fix_for_enum_converter branch from 7beff24 to ff03da3 Compare July 19, 2020 12:29
Signed-off-by: Cristiano V. Gavião <[email protected]>
@vietj vietj merged commit b7eb560 into vert-x3:master Oct 20, 2021
@vietj vietj added this to the 4.2.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants