-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Tag Provider #89
Comments
Hi @dtaveras , As you say, the MeterRegistry has common tags ; and you can get that registry to impact all registered metrics. E.g. MeterRegistry registry = BackendRegistries.getDefaultNow();
registry.config().commonTags("user", "alice"); Is that not what you're looking for? |
I was more interested in being able to extract more information based on the request, so having a tag provider with signature Request -> [Tag]. public interface JerseyTagsProvider {
} |
common tags will do for now, was just curious if i missed something. |
I think I get it, it seems like a good enhancement to add. |
Thanks, great job with this library. A ton of great features and easy to configure. |
@jotak do we have a contributor for this enhancement ? |
@vietj not that I know. I'm going to take a look. |
- Allows to implement a CustomTagsProvider interface to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89
- Allows to implement a CustomTagsProvider interface to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]>
- Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]>
- Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]> Signed-off-by: Joel Takvorian <[email protected]>
- Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]>
- Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]>
- Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]>
- Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes vert-x3#89 Signed-off-by: Joel Takvorian <[email protected]>
* Implement custom tags provider for HTTP metrics - Allows to implement a custom tags provider (Function: request -> Tags) to provide tags out of HttpRequest objects. - Add tests Fixes #89 Signed-off-by: Joel Takvorian <[email protected]> * Custom tag provider documentation
The generation of tags is tied to Label types. Is there a way to add a custom tag?
I do understand that there is common tags in the MeterRegistry but i was more looking for one when creating the Meter. As an example I want to tag each meter with a user
The text was updated successfully, but these errors were encountered: