Fix NPE when only batchHandler is specified (round 2) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsegismont I believe the issue with the test suite was basically that messages were being consumed by handlers before the batch handler was being set on the consumer instance. So I've just rejigged the consumer setup order in a couple of tests that were timing out because of this. Let me know if this looks okay to you 😄 |
|
@Strainy thank you, that makes sense. Can you create a PR for the @ppatierno PTAL |
Strainy
added a commit
to Strainy/vertx-kafka-client
that referenced
this pull request
Jan 9, 2025
* Revert "Revert "Fix NPE when only batchHandler is specified (vert-x3#281)" (vert-x3#282)" This reverts commit 4413c1e. * reorganize tests to configure handlers prior to assignment
tsegismont
pushed a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having another go at #281 (reverts commit 4413c1e).