vertx meta data changes final #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ruslansennov |
|
@paras-amdocs-openet thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made to the vertx consul client for the extended meta data changes
Motivation:
If there was an external service that needed to register more than 64 meta data entries (for routing i.e. IPv6 prefix ranges), the NFRA would simply fail to register that service instance.
Solution
If the NFRA detects that more than 64 meta data entries are needed, then all meta data is stored in a KV entry, rather than the service instance meta data storage.
The service instance meta data storage has a single entry, which points to the KV store entry key, holding the actual meta data.