16.0 vsf redesign ala #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming to have simpler name and be different from forked one.
Applying pre-commit rules and fixing bad code according to it.
Removing wkf from forked as it does nothing for us.
oerp-odoo
force-pushed
the
16.0-vsf-redesign-ala
branch
from
9fe40ae to
1bdef4d
Compare
AurelijaNorvaisaite
approved these changes
Dec 13, 2023
| self.env, 1, 100, "", {}, name=self.product_tmpl_bin.name | ||
| ) | ||
| # THEN | ||
| self.assertEqual(res[0], self.product_tmpl_bin) |
There was a problem hiding this comment.
Maybe it would be good to add test when searching by barcode or default code, not only name?
There was a problem hiding this comment.
It would be good to add a lot more tests. Original repo has 0 tests:)
maciej-wichowski
approved these changes
Dec 14, 2023
| yield parent | ||
| parent = parent.parent_id | ||
|
|
||
| def get_category_by_slug(self, slug): |
There was a problem hiding this comment.
usually its named by. Meaning get something by using something.
Comment on lines
32
to
38
| def _get_public_categ_slug(self, category_ids, category): | ||
| category_ids.append(category.id) | ||
|
|
||
| if category.parent_id: | ||
| category_ids = self._get_public_categ_slug(category_ids, category.parent_id) | ||
|
|
||
| return category_ids |
There was a problem hiding this comment.
This method is confusing, as it seems it has nothing to do with slug. Maybe just rename it to _get_category_with_parents or sth.
There was a problem hiding this comment.
This is leftover from fork. Actually I no longer use it. We can remove this confusing method entirely :)
| ).mapped("product_attribute_value_id") | ||
| product.variant_attribute_value_ids = [(6, 0, attribute_values.ids)] | ||
|
|
||
| variant_attribute_value_ids = fields.Many2many( |
There was a problem hiding this comment.
Field declarations should be before compute methods [docs]
There was a problem hiding this comment.
But I think I will remove this entirely as its kind of weird computation, which can also have big impact on performance and might not be very relevant.
This is a forked module previously called ``graphql_vuestorefront``. It is backwards incompatible module, so it should not be installed alongside ``graphql_vuestorefront``. Custom changes different than in forked module: * ``get_product_list`` in ``schemas.product`` now uses offset/limit in standard search instead of searching for all possible products and then slicing (which has terrible performance). * ``website_slug``: (renamed to ``slug``) got rid of translate awareness (to simplify it), and not adding slashes in slug, because slug is not supposed to have that. (on category, removed validation as it was forcing to use slash. Added unique constraint, because category slug can be entered manually). * Split odoo model files into more appropriate, to make it more readable and maintainable. * Removed ``public_categ_slug_ids`` field as it was confusing and redundant field that was very slow to compute for large amount of products. * implemented ``products`` ``category_slug`` filter. * moved Product schema domain method to ``product.template`` to be extendable. Addresses --------- * Moved address domain methods on ``res.partner`` to be extendable. * Moved preparation of partner (address) creation/update on ``res.partner to be extendable. Sale Order ---------- * Added UpdateOrder mutation to be able to update some data on sale order. Users ----- * Can pass extra data when signing up (only ``vat`` for now).
oerp-odoo
force-pushed
the
16.0-vsf-redesign-ala
branch
from
4857256 to
a01fd03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.