Code cleanup #110
Merged
Code cleanup #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup
There are new code quality checks and rules added in the recent versions of StyleCop, Sonar, and xUnit C# analyzers. Those rules trigger warnings in the current codebase.
Description
This is a code cleanup change to fix those code quality violations.
Testing steps
Automated tests should pass.
Known issues
There are three more xUnit1042 warnings for three tests because those tests use
[MemberData]attribute with non-serializable test data. Making the test data serializable will require significant changes in theVersOne.Epub.Schemaclasses (all schema classes need to have an empty constructor and all their properties need to be writable), so it's better to leave such change for a separate PR.