Better warnings for resized sub-buffers in DEBUGGING mode #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function argument to AllocSort to specify which buffers are being allocated. This makes it straightforward to print an appropriate warning message.
tueda
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Maybe, it might be worth converting the comment of AllocSort into Doxygen style, but it would be tedious and too verbose to make @param for all the parameters...
/*
#] WriteSetup :
#[ AllocSort :
*/
/**
* Routine allocates...
*
* @param[in] ...
* @return ...
*/
SORTING *AllocSort(LONG inLargeSize, ...So, I think the current PR is acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function argument to AllocSort to specify which buffers are being allocated. This makes it straightforward to print an appropriate warning message.