Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use par=1 EndSorts in ArgFactorize #565

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

jodavies
Copy link
Collaborator

If the argument (or a resulting factor) has more than SubTermsInSmall terms, a par=1 EndSort is necessary to avoid a crash here.

Fixes #563

If the argument (or a resulting factor) has more than SubTermsInSmall
terms, a par=1 EndSort is necessary to avoid a crash here.
@coveralls
Copy link

Coverage Status

coverage: 50.096% (+0.1%) from 49.968%
when pulling fbdb87b on jodavies:issue-563
into 4fc8e40 on vermaseren:master.

@jodavies jodavies modified the milestones: v5, v4.3.2 Nov 5, 2024
Copy link
Collaborator

@tueda tueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the whitespace changes, this patch appears to be the minimal set of changes necessary to fix the added test case. I think this PR is ready to merge.

@jodavies jodavies modified the milestones: v5, v4.3.2 Nov 6, 2024
@jodavies jodavies merged commit 8599601 into vermaseren:master Nov 11, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent crash when using factarg on a large expression
3 participants