Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simultaneous sort file creation by all worker threads #602

Open
tueda opened this issue Dec 20, 2024 · 0 comments
Open

Simultaneous sort file creation by all worker threads #602

tueda opened this issue Dec 20, 2024 · 0 comments

Comments

@tueda
Copy link
Collaborator

tueda commented Dec 20, 2024

#527 added code to check if the sort file can be created in ReserveTempFiles(). In TFORM, all worker threads run this check simultaneously, resulting in random failures on Windows (I guess the file is created with an exclusive lock).

I think we don't need worker threads to check the sort file availability. Only the master thread should handle this.
tueda added a commit to tueda/form that referenced this issue Dec 28, 2024
@tueda
fix(tform): restrict sort file creation check to main thread
9161839 
Restrict the sort file creation check at startup to the main thread in
TFORM. This change prevents unnecessary checks and potential race
conditions caused by multiple threads.

Close vermaseren#602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tueda