Support proto3 field presence #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you remove the |
sarahegler
force-pushed
the
proto3-field-presence
branch
from
bc6ee3d
to
f2bc9c5
Compare
|
Thanks for looking @ofpiyush - did you have a chance to test this out? |
|
@sarahegler sorry no. My dev machine conked on Saturday, I set up a new one but forgot about it by the time I'd set new one up. 🙈 I'll check today. |
ofpiyush
approved these changes
Apr 20, 2022
|
@sarahegler Thanks a ton for making this change! 🎉 @avinassh I've tested it on local, we can merge it. I'll add an optional field to our example as well as a separate PR. |
|
Thank you @sarahegler for the PR and thank you @ofpiyush for testing it. I have merged it now 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since protobuf 3.14, the
optionalkeyword can be used to distinguish between an unset and default primitive value. However, this code generator does not currently support the optional keyword; code generation of files containing theoptionalkeyword result in the following error:example.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-twirpy hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.This update is to support code generation for protobuf schemas containing the optional keyword. It mirrors this change in the corresponding go code generator here: twitchtv/twirp#332
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.