Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static and Dynamic modeldata classes for GEE interaction #469

Merged
merged 12 commits into from
Aug 29, 2024

Conversation

vergauwenthomas
Copy link
Owner

seperate class for static and dynamic modeldata.

To be merged in #467

@vergauwenthomas vergauwenthomas self-assigned this Aug 23, 2024
@vergauwenthomas
Copy link
Owner Author

vergauwenthomas commented Aug 23, 2024

  • update / fix tests
  • cleanup code
  • update docstrings
  • add module to the documentation
  • add examples in docstring
  • fix examples in the documentation

This was referenced Aug 23, 2024
@vergauwenthomas vergauwenthomas changed the title functionality done, ready for cleanup Static and Dynamic modeldata classes for GEE interaction Aug 23, 2024
@vergauwenthomas vergauwenthomas linked an issue Aug 23, 2024 that may be closed by this pull request
3 tasks
@vergauwenthomas
Copy link
Owner Author

vergauwenthomas commented Aug 27, 2024

  • see which functions are still relevant (gee_api module)

@vergauwenthomas
Copy link
Owner Author

vergauwenthomas commented Aug 29, 2024

  • non-user obstype methods with _

docs/intro.rst Outdated Show resolved Hide resolved
metobs_toolkit/dataset_core.py Outdated Show resolved Hide resolved
metobs_toolkit/plotting_functions.py Outdated Show resolved Hide resolved
@vergauwenthomas vergauwenthomas merged commit 05435f5 into gap_refactor_v0.2.2 Aug 29, 2024
10 of 11 checks passed
@vergauwenthomas vergauwenthomas deleted the simplify_modeldata branch August 29, 2024 13:54
vergauwenthomas added a commit that referenced this pull request Sep 10, 2024
* WIP: refactoring to only gap --> major implementation is done

* get IO test running

* fixed analysis class

* fix breaking test

* get gapfill and test running

* version bump and template show in IO test

* get ploting example running

* mulit inheriance of Dataset and fix of the add and irregular test

* fix modeldata test

* get qc check working

* cleanup and docstring updates

* cleanup

* logging and exmple + kwargs for interp gap

* upgrade the interpolation method to include higher order interpolation techniques

* update examples

* fixed the analysis example

* bugfix in sync + irregular demo in docs

* fix io test and cleanup doc examples/topics

* logginmodule fix + wroking on  docstrigs

* updating docstrings + print info bug fix

* fix doctest for dataset core + update lcz map

* fix docstrings and doctest in the Analysis class

* fix doctest in visuals, qc and gaps

* add see also for visual module

* cleanup files

* cleanup files

* cleanup files

* Static and Dynamic modeldata classes for GEE interaction (#469)

* functionality done, ready for cleanup

* savepoint in code clieanup

* savepoint docstring

* savepoint: text for docstrings

* docstring examples for GeeStaticModelData

* added examples in all docstrings

* docstrings in dataset_modeldata

* get tests running + direct gee plot methods on Dataset

* add Gee dataset classes and modeldata in the documentation

* fix tests

* cleanup

* test workflow windows runner

* work on the documentation

* minor changes + paper notebook compatible and tracking with new versions

* savepoint: writing docstrings in the Gap class

* Get docsring examples running

* fix identations in docstrings

* embeded plots in the documentation

* version fix

* fix gap fill test

* avoid tracking of py copies of notebooks

* fix docstring tests

* fix running devpipeline

* rm chmod

* minor code review

* savepoint codereview

* test windows runner

* rename update settings

* fix setting updater methods

* add docstrings logging and fix docsrings for settings updater

* code review fixes (deleting unused lines + sys.path inserts for all the test

* import dataset not a method but function

* fix path bug + add matplotlib in the requirements for rtd

* fix bug that creates the "=" file

* try rtd with poetry install

* fix bugs in paper ipynb

* test with rtd yaml

* new rtd yaml test

* new test rtd yaml

* sphinx build in poetry env

* test RTD yaml

* fix rtd yaml

* test yaml build doc

* sytax error in rtd yaml

* testing

* test rtd yml

* test rtd build with sphinx to requirements.txt build

* test in pre install

* requirements txt with group

* new attempt

* test rtd build

* without sudo rtd build

* without pandoc rtd build test

* without mocking dependencies

* add a pip list

* now with dependecy install

* export req in pre_install

* new test

* explicit groups

* cleanup after all testing

* spell checking

* spelling check on all files

* ready for last tests !!

* fix (last?) review points and fixes

* add ipython to documentation group for fixing error

* yaml workflow fix

* Update main_workflow.yml

* version bump + add pip install metobs to rtd builder

* pip install of self for testing

* add data in the included testdata folder for the irr and __add__ tests

* make sure that notebooks are not executed when (online) building docs

* testing

* try new fix for workflows

* update the output of the ipynb examples, so they are rendered

* do not build documentation on github

* cleanup + fix last doc issues. Ready for MERGE !!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant