Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright holder possibly incorrect #382

Closed
ashwinvis opened this issue Oct 7, 2023 · 2 comments · Fixed by #383
Closed

Copyright holder possibly incorrect #382

ashwinvis opened this issue Oct 7, 2023 · 2 comments · Fixed by #383

Comments

@ashwinvis
Copy link

The text is a valid open source license, but the holder... it must be an error, isn't it?

Copyright (c) 2018 The Python Packaging Authority

cf. openjournals/joss-reviews#5916

vergauwenthomas added a commit that referenced this issue Oct 10, 2023
@vergauwenthomas vergauwenthomas linked a pull request Oct 11, 2023 that will close this issue
@vergauwenthomas
Copy link
Owner

The text is a valid open source license, but the holder... it must be an error, isn't it?

Copyright (c) 2018 The Python Packaging Authority

cf. openjournals/joss-reviews#5916

@ashwinvis
Yes that was indeed an error, thank you for pointing it out!

(I made a pull request and merged it into the master. If the pull request does not affect the installation/package itself, then i will add them to the master without specifying a new release. Do you think this is a good strategy? I am pretty new to DevOps so i am unfamiliar with the deployment conversions.)

@ashwinvis
Copy link
Author

Great! Yes, no release is necessary when it comes to such things. However for JOSS the code will be archived towards the end, and if a release is indeed needed, because of bugfixes or changes to the documentation, it can wait until the end of the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants