fix: tarball urls for web/package (fix #1714) (#1716)

verdaccio · Feb 25, 2020 · 70a93da · 70a93da
1 parent 1f3f8cd
commit 70a93da
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/api/web/endpoint/package.ts b/src/api/web/endpoint/package.ts
@@ -7,6 +7,7 @@ import {
   parseReadme,
   formatAuthor,
   convertDistRemoteToLocalTarballUrls,
+  getLocalRegistryTarballUri,
   isVersionValid
 } from '../../../lib/utils';
 import { allow } from '../../middleware';
@@ -21,7 +22,7 @@ const getOrder = (order = 'asc') => {
   return order === 'asc';
 };
 
-export type PackcageAuthor = Package & { author: any };
+export type PackcageExt = Package & { author: any, dist?: {tarball: string} };
 
 function addPackageWebApi(route: Router, storage: IStorageHandler, auth: IAuth, config: Config): void {
   const can = allow(auth);
@@ -53,8 +54,8 @@ function addPackageWebApi(route: Router, storage: IStorageHandler, auth: IAuth,
         throw err;
       }
 
-      async function processPermissionsPackages(packages: PackcageAuthor[] = []): Promise<any> {
-        const permissions: PackcageAuthor[] = [];
+      async function processPackages(packages: PackcageExt[] = []): Promise<any> {
+        const permissions: PackcageExt[] = [];
         const packgesCopy = packages.slice();
         for (const pkg of packgesCopy) {
           const pkgCopy = { ...pkg };
@@ -64,6 +65,9 @@ function addPackageWebApi(route: Router, storage: IStorageHandler, auth: IAuth,
               if (config.web) {
                 pkgCopy.author.avatar = generateGravatarUrl(pkgCopy.author.email, config.web.gravatar);
               }
+              if (!_.isNil(pkgCopy.dist) && !_.isNull(pkgCopy.dist.tarball)) {
+                pkgCopy.dist.tarball = getLocalRegistryTarballUri(pkgCopy.dist.tarball, pkg.name, req, config.url_prefix);
+              }
               permissions.push(pkgCopy);
             }
           } catch (err) {
@@ -79,7 +83,7 @@ function addPackageWebApi(route: Router, storage: IStorageHandler, auth: IAuth,
       // @ts-ignore
       const order: boolean = config.web ? getOrder(web.sort_packages) : true;
 
-      next(sortByName(await processPermissionsPackages(packages), order));
+      next(sortByName(await processPackages(packages), order));
     });
   });