next.js: add option to use bundled runtime #10485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1994698 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
feedthejim
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
Ethan-Arrowood,
trek,
ijjk and
ztanner
as code owners
styfle
reviewed
Sep 11, 2023
styfle
reviewed
Sep 11, 2023
Co-authored-by: Steven <[email protected]>
styfle
reviewed
Sep 12, 2023
| appRouteHandlers.push(page); | ||
| } else { | ||
| appRouterPages.push(page); | ||
| } |
There was a problem hiding this comment.
This change is not behind a flag. Is that intentional?
There was a problem hiding this comment.
yes, we should have app route handlers into their own lambdas!
styfle
reviewed
Sep 12, 2023
styfle
reviewed
Sep 12, 2023
ijjk
approved these changes
Sep 12, 2023
styfle
added
area: next
pr: automerge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable that should allow us to test the bundled version for Next.js on Vercel, see vercel/next.js#52997 for reference.
The changes include:
VERCEL_NEXT_BUNDLED_SERVER