fix(cli): error on out of place run args #9445
Open
+273
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
commented
Nov 15, 2024
| if self.run_args.is_some() | ||
| && !matches!( | ||
| self.command, | ||
| None | Some(Command::Run { .. }) | Some(Command::Config) |
There was a problem hiding this comment.
We special list config since we use it for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have a bug where run args can be specified incorrectly and we'll silently ignore them.
turbo --no-daemon watchturbo --filter=foo run buildturbo --filter=foo watch buildwhich will silently ignore any arguments provided before the subcommand.This PR makes these explicit failures instead of silently ignoring them. There is a solution where we attempt to "merge" args provided on either side of the subcommand, but that would require us to switch to
clap's builder interface which would make our 80 line top level CLI interface ~1k lines. I do not think this is worth the time to go about that refactor to allow for awkward syntax.I suggest reviewing each commit individually as there was some required refactoring to unit test this behavior.
Testing Instructions
Added unit tests