Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): update next.js 15 and eslint 9 #9364

Closed
wants to merge 1 commit into from

Conversation

acomanescu
Copy link

@acomanescu acomanescu commented Oct 31, 2024

Description

This PR is a work in progress. The goal is to migrate the examples to use Next.js 15 with Eslint 9 config format.

I've decided to decouple the examples from @vercel/style-guide since it doesn't use much of that package.

Testing Instructions

Run pnpm lint in the basic example. It should show everything in green. Add a debugger statement in one of the apps or ui package and it should display a lint error.

@acomanescu acomanescu requested a review from a team as a code owner October 31, 2024 23:42
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 31, 2024
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 11:43pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:43pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:43pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:43pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:43pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:43pm

Copy link

vercel bot commented Oct 31, 2024

@acomanescu is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@anthonyshew
Copy link
Contributor

I finished up this work in #9501! Thank you for wanting to contribute and know that I looked at this PR for inspiration in some spots. Appreciate you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants