fix(tui): generate stop event on ctrl c #9296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we had used a
None
return from the input handler as a signal that the TUI should shut down. We no longer do this so we need to explicitly returnEvent::InternalStop
to signal that we should shut down the TUI.Testing Instructions
Start up a dev task with 2.2.1 and observe that on Ctrl-C the terminal is left in raw mode:
With the build from the PR you should note that the on Ctrl-C the terminal is returned to a cooked mode: