Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trace): fix compilation error in turbo-trace #9267

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Oct 16, 2024

Description

Tracer::new returns Tracer not a try-able type so we remove the ?

Future work is getting this crate covered by CI so we make sure it compiles.

Testing Instructions

It compiles now

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 3:18pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-gatsby-web ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-native-web ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-svelte-web ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-tailwind-web ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm
examples-vite-web ⬜️ Ignored (Inspect) Oct 16, 2024 3:18pm

@chris-olszewski chris-olszewski merged commit f69b43a into main Oct 16, 2024
36 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_tracing_main branch October 16, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants