-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): variables #9260
feat(query): variables #9260
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6635edc
to
cc75ac5
Compare
) -> Result<i32, Error> { | ||
let signal = get_signal()?; | ||
let handler = SignalHandler::new(signal); | ||
|
||
let variables: Variables = variables_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: (sorry if I missed a good reason not to do this) might be nice to move this down with where it's used in the hunk below this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
powerful PR for such a small line count! great!
Description
Inject variables into a query using a json file.
Testing Instructions
Added tests to
tests/query/variables.t