feat(query): variables #9260
Merged
feat(query): variables #9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicholasLYang
force-pushed
the
nicholasyang/query-variables
branch
from
6635edc
to
cc75ac5
Compare
| ) -> Result<i32, Error> { | ||
| let signal = get_signal()?; | ||
| let handler = SignalHandler::new(signal); | ||
|
|
||
| let variables: Variables = variables_path |
There was a problem hiding this comment.
suggestion: (sorry if I missed a good reason not to do this) might be nice to move this down with where it's used in the hunk below this one
dimitropoulos
approved these changes
Oct 17, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inject variables into a query using a json file.
Testing Instructions
Added tests to
tests/query/variables.t