chore(shim): add unit tests for shim parsing #9248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
commented
Oct 11, 2024
| @@ -56,6 +56,14 @@ pub struct ShimArgs { | |||
|
|
|||
| impl ShimArgs { | |||
| pub fn parse() -> Result<Self, Error> { | |||
| let invocation_dir = AbsoluteSystemPathBuf::cwd()?; | |||
There was a problem hiding this comment.
We make this call here so testing is easier. It also means we avoid calling std::env::current_dir once for each --cwd flag and reuse this value.
The only behavior change from this move is that if you:
- pass the args
turbo --cwd - Execute
turboin a directory wherecurrent_dirwould fail (process doesn't have permission to access cwd or cwd doesn't exist)
Then we will now report thecurrent_dirfailure instead of complaining that you didn't pass a value for the--cwdflag.
NicholasLYang
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking at hoisting daemon detection up to shim level so we could avoid reloading a filtered tracing layer. This ended up not being the solution I wanted, but I figured I should add the tests that I added.
Testing Instructions
Unit tests pass