-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update contributing and troubleshooting docs #9231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
force-pushed
the
chore/update-contributing
branch
from
October 8, 2024 15:07
c0d405c
to
feb7e85
Compare
NicholasLYang
force-pushed
the
chore/update-contributing
branch
from
October 8, 2024 15:09
feb7e85
to
9f580d1
Compare
tknickman
approved these changes
Oct 8, 2024
NicholasLYang
force-pushed
the
chore/update-contributing
branch
from
October 8, 2024 15:30
9f580d1
to
4243de0
Compare
NicholasLYang
force-pushed
the
chore/update-contributing
branch
from
October 8, 2024 16:23
cec3a92
to
b59bfe2
Compare
dimitropoulos
approved these changes
Oct 8, 2024
Co-authored-by: Dimitri Mitropoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran into some weird integration test failures due to wrong
npm
version. Put a note in docs and in the setup script. While I was there, added some stuff toCONTRIBUTING.md
and removed old references to Go.Testing Instructions