Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add task dependencies/dependents #9190

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Sep 26, 2024

Description

Adds direct_dependencies and direct_dependents fields to Task

Testing Instructions

Added some tests in tests/query/task.t

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 6:40pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 6:40pm

@NicholasLYang NicholasLYang marked this pull request as ready for review September 27, 2024 15:23
@NicholasLYang NicholasLYang requested a review from a team as a code owner September 27, 2024 15:23
@NicholasLYang NicholasLYang force-pushed the nicholasyang/add-task-dependencies branch from 1a1a286 to c22a4b2 Compare September 27, 2024 15:25
@NicholasLYang NicholasLYang force-pushed the nicholasyang/add-task-dependencies branch from dc5d2c2 to d1502eb Compare October 1, 2024 16:22
Copy link
Contributor Author

NicholasLYang commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NicholasLYang and the rest of your teammates on Graphite Graphite

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but we should update that integration test output

@@ -212,6 +212,6 @@ Run the query
WARNING query command is experimental and may change in the future
{
"data": {
"version": "2.1.3-canary.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should regex this so it won't fail when we update versions

@NicholasLYang NicholasLYang force-pushed the nicholasyang/add-task-dependencies branch from adb85f8 to ea55c51 Compare October 8, 2024 18:39
@NicholasLYang NicholasLYang merged commit e8ffdb8 into main Oct 8, 2024
41 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/add-task-dependencies branch October 8, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants