-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Task outputs clarifications #9185
docs: Task outputs clarifications #9185
Conversation
To avoid the impression that cache is disabled when `outputs` key is ommitted. `API reference` was more accurate for that behavior, than `Crafting your repository`.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
@boutchitos is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates! I see how this could be clearer now that you're pointing it out and think we can keep improving on your initial draft. Check out the comments and suggestions I've provided and let me know what you think.
436cef2
to
95a88cc
Compare
@anthonyshew: I applied your suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for contributing back!
To avoid the impression that cache is disabled when Task
outputs
key is ommitted.API reference
was more accurate for that behavior, thanCrafting your repository
.Description
I'm new to Turborepo, and was reading Crafting your repository. Two sections lead me to conclude that when there is no
outputs
key in a Task, then caching is disabled. I think the wording inAPI reference
is better.We have to account for Logs output even if there are no file outputs (which is really nice for linters).
Testing Instructions