updates jest/ts-jest to latest
#9155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
turbo-orchestrator
bot
added
area: examples
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
2f13ddd
to
adc2abd
Compare
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
adc2abd
to
24078b0
Compare
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
24078b0
to
a5e1d49
Compare
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
a5e1d49
to
609536c
Compare
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
609536c
to
1c754ab
Compare
turbo-orchestrator
bot
added
area: site
pkg: turbo-repository
pkg: turbo-telemetry
labels
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
1c754ab
to
2a98608
Compare
turbo-orchestrator
bot
removed
area: site
pkg: turbo-repository
pkg: turbo-telemetry
labels
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
6deb211
to
e159ce2
Compare
dimitropoulos
force-pushed
the
dimitri/ts-jest-upgrade
branch
from
e159ce2
to
02749b3
Compare
dimitropoulos
changed the title
jest, ts-jest, and @types/jest to latestjest/ts-jest to latest
dimitropoulos
requested review from
tknickman,
chris-olszewski and
NicholasLYang
dimitropoulos
commented
Oct 24, 2024
| @@ -356,9 +356,9 @@ mod test { | |||
| use crate::{task_graph::TaskDefinition, turbo_json::CONFIG_FILE}; | |||
|
|
|||
| #[test_case(r"{}", TurboJson::default() ; "empty")] | |||
| #[test_case(r#"{ "globalDependencies": ["tsconfig.json", "jest.config.js"] }"#, | |||
| #[test_case(r#"{ "globalDependencies": ["tsconfig.json", "jest.config.ts"] }"#, | |||
There was a problem hiding this comment.
I was unsure about this at first, but it seems to be happy. please double-check.
dimitropoulos
commented
Oct 24, 2024
dimitropoulos
commented
Oct 24, 2024
tknickman
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
there's a lot here, but I tried to make it easier to review by doing a good job of separating the different phases of the PR into their own commits - so for this one you'll probably have a much better review experience if you read commit-by-commit.
I noticed that we were getting lots of errors when running tests due to running an unsupported version of TypeScript (as compared to what our version of
jestknew about). This is solved by updating our dependencies. Coincidentally, there's a good few reasons to upgrade anyway, so this comes at a good time.Follow-ups after this PR
"lint": "eslint src/"in 16 packages, which skips the test files. Start linting tests (which, will involve fixing lints in tests).get-turbo-upgrade-command.test.ts) are timing out on GitHub Actions, and we believe the cause is running out of I/O (which the tests do a lot of). Attempt to fix this by moving to an in-memory filesystem for tests.Testing Instructions
run
pnpm test