feat(turbo): COREPACK_HOME to default passthrough #9151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
approved these changes
Sep 16, 2024
chris-olszewski
deleted the
tomknickman/turbo-4027-add-corepack_home-to-default-pass-through
branch
onsclom
added a commit
to vercel/vercel
that referenced
this pull request
Oct 3, 2024
## Problem Turborepo does not pass `COREPACK_HOME` to internal libraries. This means Turborepo projects using corepack may run into `EEXIST: file already exists` errors. [[email protected] has `COREPACK_HOME` in default passthrough](vercel/turborepo#9151), but we need to handle older existing Turborepo projects better for a couple reasons: 1. New Turborepo projects can be created today that use corepack, and they can hit this confusing `EEXIST` error. 2. We want to fix corepack detection in monorepos without breaking existing Turborepo projects again. a. #12099 ## Solution When a Turborepo project does not support `COREPACK_HOME`, we disable corepack. Projects that need corepack disabled have the following criteria: - Use turbopack (detected by having `turbo` in `package.json#devDependencies`) - Use a turbo version lower than 2.1.3 (using the minimum of the range in `package.json#devDependencies.turbo`) - Do not include `COREPACK_HOME` in `turbo.json#globalPassThroughEnv` In the case we disable corepack, we display a helpful warning telling users how to fix their project: "Warning: Disabling corepack because it may break your project. To use corepack, either upgrade to `[email protected]+` or include `COREPACK_HOME` in `turbo.json#globalPassThroughEnv`."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
COREPACK_HOMEto default passthrough listTesting Instructions