-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow usage of turbo
without turbo.json
#9149
Merged
chris-olszewski
merged 10 commits into
main
from
chrisolszewski/fdrtn-177-allow-running-turbo-without-turbojson
Sep 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2a15d31
chore(turbo_json): split out single package mode
chris-olszewski a9ba58f
chore(turbo_json): move loading to loader struct
chris-olszewski 3d2c541
chore(task_access): move task access turbo.json loading into loader
chris-olszewski e3c9430
chore(turbo_json): change turbo.json loading to be package based inst…
chris-olszewski 349042d
chore(engine): move turbo.json caching to loader
chris-olszewski e723c30
feat(turbo_json): add loader for monorepo without turbo.json
chris-olszewski cfc2c2d
feat: allow for using turbo without a turbo.json
chris-olszewski 3279a96
chore(engine): minor pr taste fixups
chris-olszewski 6ebb8ef
chore(turbo_json): take package iterator for workspace construction
chris-olszewski 6af8473
feat(env mode): allow for tasks to override the global env mode (#9157)
chris-olszewski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be worth keeping some span info here. We can take the script span from
package.json
and use it as the task definition locationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having trouble getting spans for the script names as
BTreeMap
requiresimpl Ord for Spanned<T>
which has issues since it containsRange
which doesn't implementOrd
.I don't think this is worth the effort to plumb through. The only place this span would get used would be for validating no package task syntax and having that error point to a
package.json
isn't helpful when we're the ones generatingturbo.json
.