feat: turbo-trace #9134
Merged
feat: turbo-trace #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
force-pushed
the
nicholasyang/turbo-trace
branch
from
da14f3e
to
80fcd19
Compare
chris-olszewski
approved these changes
Sep 19, 2024
crates/turbo-trace/src/tracer.rs
Outdated
| // Convert found imports/requires to absolute paths and add them to files to | ||
| // visit | ||
| for (import, span) in finder.imports() { | ||
| let file_dir = file_path.parent().unwrap_or(&self.cwd); |
There was a problem hiding this comment.
I think an expect might be more appropriate than .unwrap_or here since None would mean that we're currently process the root dir.
| } | ||
|
|
||
| impl File { | ||
| pub fn new(run: Arc<Run>, path: AbsoluteSystemPathBuf) -> Self { |
There was a problem hiding this comment.
Not blocking, but would it make sense to just pass in repo_root instead of the entire Run object? It would make writing unit tests a lot easier.
There was a problem hiding this comment.
Eventually I want to be able to map from a file to affected packages, so that will require the whole run object
NicholasLYang
force-pushed
the
nicholasyang/turbo-trace
branch
from
928bcef
to
26e893a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A long long time ago we had a node-file-trace implementation in the repository. Unfortunately this was tied to turbopack and the turbo-tasks code. Since that's now in a different repository, we're gonna implement our own version, because that's easier than coordinating multi-repo dependencies.
This implementation uses
oxc_resolverandswcto resolve dependencies and parse files.This PR hooks it up to
turbo querybut we'll probably have other uses later.Testing Instructions
Adds some tests in
turbo-trace.tusingquery