Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New --filter syntax #81

Closed
wants to merge 1 commit into from
Closed

New --filter syntax #81

wants to merge 1 commit into from

Conversation

jaredpalmer
Copy link
Contributor

Closes #27. Implements PNPM-like --filter syntax

  • Convert PNPM parse filter to Go
  • Refactor scope functions for new filter parser
  • Deprecate --scope with warning (attempt backwards compat?)
  • Update documentation

@vercel
Copy link

vercel bot commented Dec 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/Fo6GuSv6nBN7qJnViz2PdJFphUoT
✅ Preview: https://turbo-site-git-pnpm-filter-3.vercel.sh

@jaredpalmer jaredpalmer self-assigned this Dec 12, 2021
@jaredpalmer jaredpalmer added area: docs Improvements or additions to documentation pr: work in progress labels Dec 20, 2021
@weyert
Copy link
Contributor

weyert commented Dec 21, 2021

Pretty excited about this

@Necmttn
Copy link

Necmttn commented Jan 17, 2022

Looking forward to this!

@leonardssh
Copy link

I thought --scope worked the same way as pnpm --filter, but apparently it doesn't.
I kept wondering if someone actually thought of proposing this, I'm looking forward to this feature. 😍

@weyert
Copy link
Contributor

weyert commented Feb 5, 2022

Any news on this PR? Can we help in some way?

@ragrag
Copy link
Contributor

ragrag commented Feb 12, 2022

can't wait for this one, would make life so much easier without all the --scope and --ignore hacks

@rxliuli
Copy link

rxliuli commented Feb 28, 2022

Is there any progress on this PR?

@danielweck
Copy link

I have tried all possible combinations and glob syntaxes of --scope and --ignore ... to no avail ( #445 (comment) )
This is a blocker in one of my projects where I must be able to skip / ignore / exclude / filter specific packages (by name literal or regexp, or even path glob) when running a particular task name.
Is there anything significant blocking progress on this new filter feature? Or is it just still a draft PR due to lack of time or because of other higher priorities?
Cheers :)

@mcrowder65
Copy link

@danielweck i believe it's based off of the name in each package.json, see my build:one and build:two scripts here: https://github.com/mcrowder65/turborepo-example/blob/main/package.json

@danielweck
Copy link

Hi Matt, yes, --scope applies to package names, whereas --ignore works with path globs. My project contains many monorepo sub-packages so a whitelist/allowlist is not a viable option. Therefore I need to be able to use a blacklist/denylist, which the ! negation syntax would enable, but it turns out nothing works (I had fun with the entire combinatory explosion, just like other reporters in the issue tracker).

@jaredpalmer
Copy link
Contributor Author

Continued here: #887

sokra added a commit that referenced this pull request Oct 25, 2022
feat: resolve css imports and add docs
sokra pushed a commit that referenced this pull request Oct 25, 2022
@ForsakenHarmony ForsakenHarmony deleted the pnpm-filter-3 branch January 9, 2023 16:44
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants