chore: deny all clippy lints on turborepo clippy run #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
ForsakenHarmony
approved these changes
Oct 16, 2023
|
mehulkar
approved these changes
Oct 17, 2023
chris-olszewski
added a commit
that referenced
this pull request
Oct 17, 2023
### Description #6186 and #6187 raced and landed in an order that let in a new clippy warning *and* errors on said warning ### Testing Instructions No clippy warnings Closes TURBO-1477 Co-authored-by: Chris Olszewski <Chris Olszewski>
chris-olszewski
deleted the
olszewski/chore_deny_clippy_all_for_turborepo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes clippy warnings blocking for any crate that's a member of the
turborepocargo group.Testing Instructions
At the time of writing main has clippy warnings and this should fail. If #6185 gets merged and this PR gets rebased, then there won't be any warnings to error out on.