Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): webpack nmt #5848

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

tknickman
Copy link
Member

Description

Fix webpack nmt lint

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:33pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:33pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:33pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:33pm

@tknickman tknickman requested a review from sokra August 31, 2023 14:23
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust benchmark tests (mac/win, non-blocking)
  • Turbopack Rust benchmarks (non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Linux Benchmark for 95674ca

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5281.97µs ± 26.14µs 5271.49µs ± 27.84µs -0.20%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4930.90µs ± 25.77µs 5035.47µs ± 135.58µs +2.12%
bench_startup/Turbopack CSR/1000 modules 971.46ms ± 1.63ms 973.33ms ± 2.10ms +0.19%

@tknickman tknickman merged commit 3e47944 into main Sep 1, 2023
55 of 58 checks passed
@tknickman tknickman deleted the tomknickman/turbo-1286-fix-webpack-nmt branch September 1, 2023 18:15
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants